Skip to content

fix(skills): CodeQL code-quality — missing comma, empty except, unused import #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmadcode merged 2 commits into from
Aug 29, 2026
Merged

fix(skills): CodeQL code-quality — missing comma, empty except, unused import #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2edeaa8
fix(skills): clear CodeQL code-quality findings in Python builders
Aug 9, 2026
2396786
fix(skills): merge implicit list concatenations instead of splitting …
Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions samples/bmad-agent-code-coach/scripts/init-sanctum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,17 +163,14 @@ def generate_capabilities_md(capabilities: list[dict], evolvable: bool = False)
if evolvable:
lines.extend([
"",
"This agent is **evolvable** — you can teach it new skills, modify existing "
"ones, and retire capabilities that aren't useful. The built-in capabilities "
"above are starting points, not limits.",
"This agent is **evolvable** — you can teach it new skills, modify existing ones, and retire capabilities that aren't useful. The built-in capabilities above are starting points, not limits.",
])

lines.extend([
"",
"## Tools",
"",
"Prefer crafting your own tools over depending on external ones. A script you wrote "
"and saved is more reliable than an external API. Use the file system creatively.",
"Prefer crafting your own tools over depending on external ones. A script you wrote and saved is more reliable than an external API. Use the file system creatively.",
"",
"### User-Provided Tools",
"",
Expand Down
3 changes: 1 addition & 2 deletions samples/bmad-agent-creative-muse/scripts/init-sanctum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,7 @@ def generate_capabilities_md(capabilities: list[dict]) -> str:
"",
"## Tools",
"",
"Prefer crafting your own tools over depending on external ones. A script you wrote "
"and saved is more reliable than an external API. Use the file system creatively.",
"Prefer crafting your own tools over depending on external ones. A script you wrote and saved is more reliable than an external API. Use the file system creatively.",
"",
"### User-Provided Tools",
"",
Expand Down
3 changes: 1 addition & 2 deletions samples/bmad-agent-sentinel/scripts/init-sanctum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,7 @@ def generate_capabilities_md(capabilities: list[dict], evolvable: bool) -> str:
"",
"## Tools",
"",
"Prefer crafting your own tools over depending on external ones. A script you wrote "
"and saved is more reliable than an external API. Use the file system creatively.",
"Prefer crafting your own tools over depending on external ones. A script you wrote and saved is more reliable than an external API. Use the file system creatively.",
"",
"### User-Provided Tools",
"",
Expand Down
3 changes: 1 addition & 2 deletions skills/bmad-agent-builder/assets/init-sanctum-template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,7 @@ def generate_capabilities_md(capabilities: list[dict], evolvable: bool) -> str:
"",
"## Tools",
"",
"Prefer crafting your own tools over depending on external ones. A script you wrote "
"and saved is more reliable than an external API. Use the file system creatively.",
"Prefer crafting your own tools over depending on external ones. A script you wrote and saved is more reliable than an external API. Use the file system creatively.",
"",
"### User-Provided Tools",
"",
Expand Down
1 change: 1 addition & 0 deletions skills/bmad-agent-builder/scripts/render_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ def atomic_write(path: Path, text: str) -> None:
try:
os.unlink(tmp)
except OSError:
# Best-effort temp cleanup; original error must still propagate.
pass
raise

Expand Down
1 change: 1 addition & 0 deletions skills/bmad-module-builder/scripts/scaffold-standalone-module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ def main() -> int:
elif stripped.startswith("module_version:"):
module_version = stripped.split(":", 1)[1].strip().strip('"').strip("'")
except Exception:
# Optional metadata — keep marketplace defaults when module.yaml is missing/unreadable.
pass

skill_dir_name = skill_dir.name
Expand Down
1 change: 1 addition & 0 deletions skills/bmad-workflow-builder/scripts/render_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ def atomic_write(path: Path, text: str) -> None:
try:
os.unlink(tmp)
except OSError:
# Best-effort temp cleanup; original error must still propagate.
pass
raise

Expand Down
1 change: 0 additions & 1 deletion skills/bmad-workflow-builder/scripts/tests/test_canon_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
Run with: python3 -m pytest test_canon_sync.py
(or plain `python3 test_canon_sync.py` for a lightweight self-check).
"""
import sys
from pathlib import Path

SKILLS_DIR = Path(__file__).resolve().parents[3]
Expand Down
Loading