Fix Windows renderer staging ACL inheritance - #2734
Draft
kingbentley wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tempfile.mkdtemp()and private0700behavior on non-Windows platformstest:rendererquality pathRoot cause
Python 3.11.10 and newer specially handle
mkdir(..., 0o700)on Windows by creating a protected ACL for the owner, SYSTEM, and administrators.tempfile.mkdtemp()uses that mode. In a restricted sandbox, the protected ACL drops inherited workspace principals, so the renderer can create its staging directory but is denied when writing the first snapshot file.Impact
Sandboxed Windows rendering can publish immutable workflow snapshots without requiring an unsandboxed workaround. Existing atomic rename, concurrent-winner verification, cleanup, destination layout, and POSIX security behavior remain unchanged.
Validation
npm cinpm run qualityunder WSL with Node 22.23.2 and uv 0.12.4 — passedworkflow.mdwas readable from a separate sandboxed process