Skip to content

preserve precision during forward() - #429

Open
prjemian wants to merge 11 commits into
mainfrom
427-forward-solution-near-90-degrees
Open

prjemian wants to merge 11 commits into
mainfrom
427-forward-solution-near-90-degrees

Conversation

@prjemian

Copy link
Copy Markdown
Collaborator

Preserve full-precision solver values through forward-solution cut-point wrapping and constraint validation. Round accepted user-facing positions using diffractometer.digits.

Tests:

  • pytest ./src/hklpy2: 1300 passed, 7 skipped, 8 deselected
  • PRE_COMMIT_HOME=/tmp/pre-commit-JEMIAN pre-commit run --all-files: passed

Agent: OpenCode (gpt56luna)

Agent: OpenCode (gpt56luna)
Agent: OpenCode (gpt56luna)
Agent: OpenCode (gpt56luna)
@prjemian prjemian added the bug Something isn't working label Sep 25, 2026
@prjemian prjemian self-assigned this Sep 25, 2026
Agent: OpenCode (gpt56luna)
@coveralls

coveralls commented Sep 25, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 36635521338

Coverage remained the same at 100.0%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 3 of 3 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3667
Covered Lines: 3667
Line Coverage: 100.0%
Coverage Strength: 3.99 hits per line

💛 - Coveralls

disable micromamba environment caching only for experimental (Python 3.15-dev) while preserving caching for supported versions.
Agent: OpenCode (gpt56luna)
Agent: OpenCode (gpt56luna)
Agent: OpenCode (gpt56luna)
Agent: OpenCode (gpt56luna)
@prjemian prjemian changed the title fix #427 preserve precision during forward constraints preserve precision during forward constraints Oct 8, 2026
@prjemian prjemian changed the title preserve precision during forward constraints preserve precision during forward() Oct 8, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: calculating reflections that are separated in angle close to 90 degrees

2 participants