Skip to content

Fix axis validation with NumPy 2.5 - #426

Merged
prjemian merged 3 commits into
mainfrom
CI-fail
Aug 25, 2026
Merged

prjemian merged 3 commits into
mainfrom
CI-fail

Conversation

@prjemian

@prjemian prjemian commented Aug 25, 2026 •

Copy link
Copy Markdown
Collaborator
  • NumPy 2.5 changed numpy.typing.NDArray to a parameterized TypeAliasType, which typeguard 4.6.0 accepts without checking and caused invalid axis inputs to reach value validation.

Use an explicit numpy.ndarray annotation for AxesArray, preserving integer and floating-point axis arrays while restoring runtime container checks. Keep numeric element validation at the axes_to_dict() input boundary. Install Tiled server extras in development environments because the tests instantiate SimpleTiledServer; this also prevents mixed conda/pip Python 3.14 environments from omitting Strawberry GraphQL.

Validation:

  • pre-commit run --all-files
  • pytest -q src/hklpy2 (1293 passed, 7 skipped, 8 deselected)
  • focused regression suite with NumPy 2.5.2 (52 passed)
  • pytest -q src/hklpy2/tests/test_utils.py::test_list_orientation_runs (4 passed)

Agent: OpenCode (gpt56sol)

Agent: OpenCode (gpt56sol)
@prjemian prjemian added this to the v1.0 release milestone Aug 25, 2026
@prjemian prjemian self-assigned this Aug 25, 2026
@coveralls

coveralls commented Aug 25, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 32892156943

Coverage at 100.0% (no base build to compare)

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3665
Covered Lines: 3665
Line Coverage: 100.0%
Coverage Strength: 4.99 hits per line

💛 - Coveralls

@prjemian
prjemian merged commit b428216 into main Aug 25, 2026
12 checks passed
@prjemian
prjemian deleted the CI-fail branch August 25, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants