fix(staged): hide keyboard shortcut hints on touch devices#730
Open
matt2e wants to merge 5 commits into
Open
Conversation
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
The prior collapse into a match guard moved `data` (Bytes, not Copy) out of the pattern, which the borrow checker rejects. Clippy is happy with the original nested-if form, so restore it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The lint's suggested match-guard fix doesn't compile (Bytes isn't Copy and can't be moved into the guard), so suppress it at the function level with a note explaining why future attempts to collapse will fail. Signed-off-by: Matt Toohey <contact@matttoohey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(pointer: coarse)and(hover: none)media queries and expose a reactiveshowShortcutHintsflag on the sharedviewportstateTest plan
⌘↵,⌘N,Escin tooltips) still appear🤖 Generated with Claude Code