Repository navigation
Rollout: declare Effect and Foldkit as peer ranges - #64
Merged
Merged
Conversation
Cloudflare Preview DeployedPlayground: https://schematics-playground-pr-64-ezvkv3gra3pl6oby.bjacobso.workers.dev Built from commit 2026-11-01T21:16:29.718Z This comment updates automatically with each push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
peer-ranges: Schematics libraries now declare Effect and@effect/platform-nodeas peers through a namedpeerscatalog with^4.1.1ranges. Exact4.1.1development pins remain in the default catalog. CLI and IDE also declare their existing runtime use of Effect as a peer.Updated the consumer guide to install the peers and copy both catalogs, plus its
llms.txtentry. Foldkit is used only by the private playground app, so its application dependencies stay in place. All locked package resolutions and existing scoped compatibility exceptions are unchanged.Verification with Node 25.9.0 and pnpm 11.1.3:
pnpm install --frozen-lockfile --strict-peer-dependenciespassed.pnpm checkpassed: formatting, docs validation, 274 package tests (including CLI consumer tests), types, builds, and local HTTP smoke.package.json: relevant peers resolve to^4.1.1, development dependencies to4.1.1, and none remain in regular dependencies.SCHEMATICS_E2E_MODE=landing-production pnpm playground:e2e tests/app/landing.spec.ts tests/app/package-pages.spec.ts --output ../../.context/browser-resultspassed all 18 tests, including Foldkit demos and opening the IDE.The first cold check hit five-second timeouts in two CLI tests during parallel builds; the complete rerun passed without test changes. No blockers remain.
Final status: complete;
peer-rangesaddressed and ready for review.Open workspace in Conductor