Repository navigation
Fix changeset validation for generated release PRs - #115
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated release PRs fail because Changesets consumes their release notes while
pnpm checkstill requires pending changesets whenever package files differ frommain.Run changeset validation as an explicit CI step on ordinary PRs, keep the full code and package checks on release PRs and
main, and document when release-note validation applies.Validated the patch on release PR #14:
pnpm release:checkpassed, including 1,243 unit tests, 248 surface comparisons, docs validation, and all four packed-package consumer checks;pnpm test:sitealso built the assembled website and passed all nine browser tests.Open workspace in Conductor