Skip to content

fix accelerometerCollector - #335

Open
shkoder wants to merge 1 commit into
bitwiseshiftleft:masterfrom
shkoder:master
Open

fix accelerometerCollector#335
shkoder wants to merge 1 commit into
bitwiseshiftleft:masterfrom
shkoder:master

Conversation

@shkoder

@shkoder shkoder commented May 17, 2017

Copy link
Copy Markdown

fix accelerometerCollector for the case when ev.accelerationIncludingGravity is null (w3c/deviceorientation@ca8af6b)

@shkoder

shkoder commented May 17, 2017

Copy link
Copy Markdown
Author

tests fail because of google/closure-compiler#2487

@Nilos

Nilos commented May 18, 2017

Copy link
Copy Markdown
Collaborator

Any ideas on how we could get the tests green again?

@shkoder

shkoder commented May 18, 2017

Copy link
Copy Markdown
Author

The easiest way to is revert ae73ae7 and b179f12
When the closure compiler issue is resolved, they can be brought back.

@shkoder

shkoder commented May 18, 2017

Copy link
Copy Markdown
Author

e.g. #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants