Repository navigation
Clean up after bumping lower bound to GHC 9.6 - #65
Merged
Merged
Conversation
- Raise base lower bound to 4.18, add tested-with, bump to 2.5.0 - Remove imports that are redundant with Prelude (<$>, <>, Monoid, Semigroup) and the unnecessary Typeable deriving on KeyError - Delete the stale .travis.yml and .hgignore Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
prometheus-ghc-stats pins prometheus <2.5, so bumping to 2.5.0 broke dependency resolution for the in-tree ghc-stats build. Releasing is a separate decision, so list the change under "Unreleased" instead. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #64. This branch is stacked on #64's commit, so until #64 merges the diff here also shows its changes (GitHub can't base a PR on a fork branch). Only the top commit is new.
Changes
prometheus.cabal: raisebaselower bound to>= 4.18(what GHC 9.6 ships), addtested-withmatching the CI matrix, and leave the version unchangedCHANGELOG.md: note the new minimum GHC under an "Unreleased" headingControl.Applicative ((<$>)),Data.Monoid ((<>)),Data.Monoid (Monoid),Data.Semigroup (Semigroup)DeriveDataTypeable/Typeablederiving onKeyError(all types areTypeableautomatically).travis.yml(GHC 8.0–8.6 on Travis, replaced by GitHub Actions) and.hgignoreReview notes
prometheus-ghc-statscapsprometheus <2.5, and releasing is a separate decision.text,containers,bytestring,transformers) are intentionally left alone.stack.yamlandstack-9.10.yamlare identical; one could be removed.Test plan
🤖 Generated with Claude Code