Skip to content

Add new V3 API following Prometheus spec - #62

Open
brandonchinn178 wants to merge 11 commits into
bitnomial:masterfrom
brandonchinn178:v3
Open

brandonchinn178 wants to merge 11 commits into
bitnomial:masterfrom
brandonchinn178:v3

Conversation

@brandonchinn178

Copy link
Copy Markdown
Contributor

Fixes #59
Fixes #39

@riz0id riz0id left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only hard feedback is about the globalRegistry

Comment thread src/System/Metrics/Prometheus/Metric.hs
Comment thread src/System/Metrics/Prometheus/Metric/Histogram.hs Outdated
Comment thread src/System/Metrics/Prometheus/Metric.hs
Comment thread src/System/Metrics/Prometheus/Metric/Counter.hs
Comment thread src/Prometheus/V3/Metric/Base.hs
Comment thread src/Prometheus/V3/MetricName.hs Outdated
Comment thread src/Prometheus/V3/Name.hs
Comment thread src/Prometheus/V3/Name.hs
Comment thread src/Prometheus/V3/Registry.hs Outdated
Comment thread src/Prometheus/V3/Registry.hs Outdated
@brandonchinn178
brandonchinn178 force-pushed the v3 branch 3 times, most recently from d4655c1 to 21c1f98 Compare June 29, 2026 22:29
@brandonchinn178
brandonchinn178 marked this pull request as ready for review October 7, 2026 19:18
Comment thread src/System/Metrics/Prometheus/Metric/Histogram.hs Outdated
Comment thread src/Prometheus/V3.hs
Comment thread src/Prometheus/V3/Metric/Labelled.hs
Comment thread src/System/Metrics/Prometheus/Metric/Counter.hs
Comment thread src/Prometheus/V3/Metric/Labelled.hs Outdated
Comment thread prometheus.cabal Outdated

@wraithm wraithm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Claude (posting on behalf of @wraithm): a few small notes inline, plus replies on existing threads. All non-blocking except the histogram bucket one. Thanks for the great work on this!

Comment thread src/System/Metrics/Prometheus/Metric/Histogram.hs Outdated
Comment thread src/Prometheus/V3/Metric/Histogram.hs Outdated
Comment thread src/Prometheus/V3/Encode.hs
Comment thread src/Prometheus/V3/Registry.hs Outdated
Comment thread src/Prometheus/V3/Metric/Base.hs Outdated
Comment thread src/Prometheus/V3/Sample.hs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow standard Prometheus client library API Allow non-Double Gauges

3 participants