fix(sftp): preserve browsed paths across tab snapshot transitions - #3296
Open
binaricat wants to merge 1 commit into
Open
fix(sftp): preserve browsed paths across tab snapshot transitions#3296binaricat wants to merge 1 commit into
binaricat wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
@codex review |
binaricat
marked this pull request as draft
September 6, 2026 10:10
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
netcatty-bot
marked this pull request as ready for review
September 6, 2026 10:12
Collaborator
|
Codex reported no major issues. This PR is marked ready for human review/merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switching away from an SSH terminal and back could still reset its SFTP browser to the terminal cwd and clear its filename filter, despite #3232. The panel briefly consumed the previous tab's live context before the new tab's publisher committed, invalidating cwd tracking and sometimes replacing the SFTP connection.
Keep each panel's last matching terminal/workspace snapshot during that publication gap. Unrelated snapshots are ignored, fresh panels wait for their owner, and actual cwd or focused workspace-pane changes still propagate.
Type of Change
Related Issue (optional)
Follow-up to #3232; related to #3230.
Changes Made
Screenshots / Demo
Reproduced twice in the actual
npm run devElectron app against an SSH host: enable follow terminal directory, browse a different folder, filter to one file, switch to a local tab and back. Before the fix the path returned to/rootand the filter disappeared. A temporary trace showed the local tab's focused session entering the remote panel before its own snapshot arrived; no panel remount was required.After the fix, the same UI steps preserved the folder and filter. A real
cdstill moved the SFTP browser to the new directory. Final source was retested in the development app. Diagnostic logging was removed.Testing
npm run dev)npm run lint)npm test) — full suite not rerunnpm run generate:capability-tools) — not applicable124 focused tests pass across live snapshot isolation, SFTP follow, connection reuse/memory, side-panel wiring, and the tab bridge. The new regression test was run against the old hook and failed because
local-breached thessh-apanel; it passes with this fix.Checklist