Repository navigation
docs: add missing MangaBaka config section and fix README drift - #100
Merged
Merged
Conversation
…rom code MangaBaka shipped without a section in either YAML example and was described as enabled by default while it is off. Also fixes other statements that disagree with the code: legacy CLIENT_SECRET_* only work with a config file, OAUTH_PORT falls back to PORT, favorites log lines name the media type, and only four env vars are validated.
…e registry The existing docs test only covered the flag table and env var list, so a source missing from both YAML examples or described with the wrong default passed CI. The new checks derive the YAML key from the Config struct tag, so a future source cannot be forgotten silently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MangaBaka (#97) was added to the README flag table and env var list, but not to either YAML example (README
config.yamlblock,config.example.yaml). The strategy chains also called it "enabled by default", while its default isfalse. The existing docs test only checks the flag table and env var list, so neither mistake failed CI.What
mangabaka_apisection to both YAML examples and fix the default wording in the strategy chains and notes.CLIENT_SECRET_*env vars only work together with a config fileOAUTH_PORTfalls back toPORTdocs_test.go: check that every source inmappingSources()has a section in both YAML examples with the rightenabledvalue, and that README prose uses the right "enabled/disabled by default". Both checks failed before the docs fix.CLAUDE.md: add the YAML examples and chain wording to the checklist for adding a source.