Skip to content

chore: sync Nova app discovery - #192

Merged
bigduu merged 1 commit into
mainfrom
zenith/chore/185-nova-app-discovery
Sep 5, 2026
Merged

bigduu merged 1 commit into
mainfrom
zenith/chore/185-nova-app-discovery

Conversation

@bigduu

@bigduu bigduu commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Zenith now pins the merged Nova app-discovery implementation. Callers can use the optional inspect_app tool with an application name or bundle ID, while runtime, process and local CDP endpoint discovery remain internal.

Summary

Submodule Updates

Submodule Previous commit New commit Rationale
nova 8f029d22dbc9ab317a68560788d1e6360b71120e b79893b412ccd3020b7eb118e32f6b2b0cbca5f7 Merged app discovery with one compact public operation, bounded process-owned CDP metadata checks, and no-endpoint application discovery.

Test Plan

  • Root diff contains exactly one mode-160000 gitlink; git diff --check passes.
  • The Nova merge tree exactly matches independently reviewed head 159af8e177cdf475c0b3dd5319727e95dc842314.
  • All six Nova CI jobs passed in run 33949545136, including macOS tests, Linux headless tests, Windows cross-check, extension/native-host tests and release checks.
  • Exact-commit local acceptance passed with a test-owned Electron app both without CDP and with an internally enabled random CDP port. Discovery left the app running in both phases.
  • Independent root pointer review and Submodule Guard must pass before merge.

No graphical UI is changed.

Refs #185.

@bigduu bigduu added the review:needed Waiting for review label Sep 5, 2026
@bigduu

bigduu commented Sep 5, 2026

Copy link
Copy Markdown
Owner Author

Independent agent review approved exact head 2d99b35baa43d352b1200b9aaf1c892319136917 against base a3e111d928135ac4216470f5916a0652ad4f3b09.

Reviewer bodhi_nova_boundary verified a clean worktree and exactly one mode-160000 nova gitlink change, from 8f029d22dbc9ab317a68560788d1e6360b71120e to b79893b412ccd3020b7eb118e32f6b2b0cbca5f7. All other files and submodule revisions remain identical to the base. The target is the actual Nova #43 squash merge on master, with the same tree as the independently reviewed and tested Nova head. Nova #42 is closed. The PR body includes the required submodule notes and accurately preserves the remaining scope in #185. No blocking finding.

Root gate: both Submodule Guard checks passed in run 33950176765. Live head/base match the review, the PR is clean and mergeable, no review threads or requested changes exist, and branch protection does not require a human approval.

@bigduu bigduu added review:agent Agent review complete; merge gates may proceed and removed review:needed Waiting for review labels Sep 5, 2026
@bigduu
bigduu merged commit 847c914 into main Sep 5, 2026
2 checks passed
@bigduu
bigduu deleted the zenith/chore/185-nova-app-discovery branch September 5, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:agent Agent review complete; merge gates may proceed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[nova] feat: discover Chromium apps even without an exposed CDP endpoint

1 participant