fix: validate universal app binaries with supported lipo order (#45) - #52
Merged
Merged
Conversation
Use lipo's input-file-first verify_arch grammar for both the source binary and the copy installed into Nova.app. Strengthen the release workflow fixture so the historical order fails and thin binaries are rejected before signing or archiving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lipo's supported input-file-first-verify_archgrammar for both the source universal executable and the copy installed intoNova.appCloses #45
Test plan
Automated / hermetic
git diff --checkbash -n packaging/macos/package-development-app.sh scripts/test-release-workflow.shscripts/test-release-workflow.shlipo -verify_arch arm64 x86_64 <input>Real macOS/Xcode acceptance
Used the installed universal
nova 0.2.1executable (x86_64 arm64):lipo <binary> -verify_arch arm64 x86_64exited 0/tmpoutputx86_64 arm64codesignverificationcom.zenith.novabundle identity and exact0.2.1plist fields--version/--helplipocheck beforecodesignordittoNon-goals