Skip to content

fix: update Windows pixel loops for Clippy - #28

Merged
bigduu merged 1 commit into
masterfrom
nova/fix/27-windows-clippy
Aug 30, 2026
Merged

bigduu merged 1 commit into
masterfrom
nova/fix/27-windows-clippy

Conversation

@bigduu

@bigduu bigduu commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace the two Windows BGRA iteration sites flagged by Rust 1.98 Clippy with fixed-size slice chunking
  • keep the existing pixel conversion and safety behavior unchanged
  • unblock the Windows cross-check without expanding the README documentation PR

Closes #27

Test Plan

  • cargo fmt --all -- --check
  • cargo clippy --all-targets -- -D warnings
  • cargo test --all-targets
  • cargo check --target aarch64-pc-windows-msvc --all-targets
  • cargo clippy --target aarch64-pc-windows-msvc --all-targets -- -D warnings

@bigduu

bigduu commented Aug 30, 2026

Copy link
Copy Markdown
Owner Author

Independent exact-head agent review: APPROVE. Reviewed base e1c57f6 and head 426503e. No P0-P3 findings. Both Windows BGRA pixel loops preserve the old complete-four-byte grouping, remainder behavior, channel order, and WGC row-pitch handling. The diff is exactly +2/-2 in one file, raises no effective MSRV, and adds no compatibility or architectural layer. Rust 1.97 Windows cross-check/strict Clippy and all exact-head GitHub checks passed.

@bigduu bigduu added the review:agent Agent review complete; human final review may proceed label Aug 30, 2026
@bigduu
bigduu merged commit cea634c into master Aug 30, 2026
3 checks passed
@bigduu
bigduu deleted the nova/fix/27-windows-clippy branch August 30, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:agent Agent review complete; human final review may proceed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[nova] fix: update Windows pixel loops for stable Clippy

1 participant