fix: support React 18 type peers - #18
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efd74baefb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "peerDependencies": { | ||
| "@types/react": "^19.1.16", | ||
| "@types/react-dom": "^19.1.9", | ||
| "@types/react": "^18.0.0 || ^19.0.0", |
There was a problem hiding this comment.
Exclude React 18 typings that lack React.JSX
When a consumer is pinned to an early @types/react 18.x release, this range now declares the installation supported even though the emitted public declarations reference React.JSX.IntrinsicElements from src/router.ts and src/define.ts; those older typings expose only the global JSX namespace, so TypeScript reports that React has no exported member JSX. Constrain the React 18 lower bound to a release that provides React.JSX (and compile-test that lower bound), or avoid emitting React.JSX in the public types.
Useful? React with 👍 / 👎.
Summary
@types/reactand@types/react-dompeers to match YAR's React 18/19 runtime support1.3.1Validation
pnpm buildpnpm lintpnpm test -- --run(80 tests)pnpm typecheckRequired by better-stack-ai/better-stack#167 review feedback.