Skip to content

fix: support React 18 type peers - #18

Merged
olliethedev merged 1 commit into
mainfrom
fix/react-peer-compat
Aug 22, 2026
Merged

fix: support React 18 type peers#18
olliethedev merged 1 commit into
mainfrom
fix/react-peer-compat

Conversation

@olliethedev

Copy link
Copy Markdown
Collaborator

Summary

  • widen @types/react and @types/react-dom peers to match YAR's React 18/19 runtime support
  • prepare patch release 1.3.1
  • add a package metadata regression test

Validation

  • pnpm build
  • pnpm lint
  • pnpm test -- --run (80 tests)
  • pnpm typecheck
  • packed-package npm resolution with React/types 18.3 and 19.2 cohorts

Required by better-stack-ai/better-stack#167 review feedback.

@olliethedev
olliethedev merged commit 9f78f57 into main Aug 22, 2026
1 check passed
@olliethedev
olliethedev deleted the fix/react-peer-compat branch August 22, 2026 18:44

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: efd74baefb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
"peerDependencies": {
"@types/react": "^19.1.16",
"@types/react-dom": "^19.1.9",
"@types/react": "^18.0.0 || ^19.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Exclude React 18 typings that lack React.JSX

When a consumer is pinned to an early @types/react 18.x release, this range now declares the installation supported even though the emitted public declarations reference React.JSX.IntrinsicElements from src/router.ts and src/define.ts; those older typings expose only the global JSX namespace, so TypeScript reports that React has no exported member JSX. Constrain the React 18 lower bound to a release that provides React.JSX (and compile-test that lower bound), or avoid emitting React.JSX in the public types.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant