dawn_iwinfo: drop local redefinition of IWINFO_BUFSIZE - #274
Merged
PolynomialDivision merged 1 commit intoAug 10, 2026
Merged
Conversation
IWINFO_BUFSIZE is already defined by libiwinfo's <iwinfo.h>, which is included at the top of this file. Redefining it locally with a different value (24 KiB vs. 96 KiB in current libiwinfo) causes a compiler warning about macro redefinition and, more importantly, means the buffers allocated in this file are smaller than what libiwinfo may write into them. Rely on the header's definition instead. Signed-off-by: Michael Pfeifroth <micpf@westermo.com>
Collaborator
|
looks good to me thanks! |
PolynomialDivision
merged commit Aug 10, 2026
ae8e6a7
into
berlin-open-wireless-lab:master
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IWINFO_BUFSIZEis already defined by libiwinfo's<iwinfo.h>, which is included at the top ofsrc/utils/dawn_iwinfo.c. Redefining it locally with a different value (24 KiB here vs. 96 KiB in current libiwinfo) causes a compiler warning about macro redefinition, and — more importantly — means thechar buf[IWINFO_BUFSIZE]stack buffers in this file are smaller than what libiwinfo may write into them (e.g. viaiw->assoclist()).Just drop the local
#defineand rely on the header's value.No functional change beyond the buffer size following libiwinfo.