fix: preserve task response header bytes - #5711
Open
Ricky-7-Yan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR address?
Task-result response headers are serialized from ASGI's Latin-1 byte representation, but deserialization currently uses UTF-8 through the default
str.encode(). A header such asb"caf\xe9"therefore returns asb"caf\xc3\xa9"after a round trip.This change uses the serde's existing
HEADERS_ENCODINGin the response path, matching request deserialization and restoring byte-for-byte symmetry. It adds a focused regression test for a non-ASCII Latin-1 header value.This revisits the voluntarily closed #5693 from @feiiiiii5 after revalidating the behavior on current
main.Verification:
ruff check src/_bentoml_impl/tasks/serde.py tests/unit/bentoml_io/test_tasks_serde.pyruff format --check src/_bentoml_impl/tasks/serde.py tests/unit/bentoml_io/test_tasks_serde.pyAI assistance was used for implementation and test preparation; the reported commands were run locally.
Before submitting:
pre-commit run -ascript has passed? Focused Ruff lint and format checks passed; the full pre-commit suite was not run.