fix(server): propagate errors through TimeoutMiddleware - #5670
Open
hsusul wants to merge 1 commit into
Open
Conversation
Unhandled exceptions before any ASGI response previously waited for the full traffic timeout and then returned no response when cancel failed. Unblock the waiter when the request future completes and await it on the timeout race so clients get a proper 500 instead of an empty hang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR address?
When an HTTP handler raised before sending any ASGI response,
TimeoutMiddlewarewaited for the fulltraffic.timeoutand then returned no response. Clients received an empty disconnect instead of a normal 500 response.The timeout waiter previously completed only when:
If the application future had already failed,
fut.cancel()returnedFalse. The middleware then neither sent a 504 response nor awaited the future, leaving the exception unobserved.This PR:
ServerErrorMiddlewareSuccessful responses and genuine timeout responses are unchanged.
Validation
ruff formatpassedruff checkpassedpre-commitpassed on changed filespyrightcompleted with 0 errorsgit diff --checkpassedexport PYTEST_PLUGINS=bentoml.testing.pytest.plugin python -m pytest tests/unit/_internal/server/http/test_traffic.py -q