Repository navigation
comp.ts: one function makes the per-pass File state - #1507
Open
nicolas-abril wants to merge 1 commit into
Open
nicolas-abril wants to merge 1 commit into
nicolas-abril wants to merge 1 commit into
Conversation
file_pass() returns the ten fields an emitting pass writes (lend, segs, spins, spun, clos, tabs, img, lits, consts, brws). file_new spreads it, compile_book assigns a fresh one before each pass, and File takes its type, so the list is written once instead of three times. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fileheld ten fields that each emitting pass writes and the next pass clears (lend,segs,spins,spun,clos,tabs,img,lits,consts,brws). They were listed three times: in the type, infile_new, and incompile_book's clear-and-reset before each pass.file_pass()now builds them.file_newspreads it,compile_bookdoesObject.assign(FL, file_pass()), andFiletakes its type from it. This frees 62 ttok (63,929 → 63,867).Validation
mainfor all 17 runtime benches.gates/perf.tsruns againstmain. Geomean compiler 0.997, runtime 1.000.#1506 (Nat as number) deletes
marshfrom the sameFileblock, so whichever lands second needs a one-line rebase.🤖 Generated with Claude Code