Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1497.
A valid
import ./bad.bend as Bad # commentchecks the imported file normally, but--checkuptreated it as a non-import: it exited 0 without any check/run. Good commented imports were skipped too. Accept the language's trailing#comment in the existing checkup import matcher; do not change the language parser or independent per-module execution.The new permanent installed-CLI assertion checks both consequences: a commented bad import exits 1, and a commented good import actually runs and returns
5n. Existing uncommented checkup/closed-reader controls remain. The exact new assertion fails on unchanged source behavior and passes with the real rebuilt standalone CLI. No diagnostic wording or implementation-source assertions. README documents aliased checkup imports; hand-written GUIDE/CHANGELOG are unchanged.Actual Linux x64 verification:
bun gates/repo.ts: 54/54; permanent caps and gate policy unchanged.Full installer/archive/hub ping was not run because the sibling site checkout is unavailable; isolated assertion proof is not a claim that the full ping gate passed.