Fix FTS dumps and cross-thread pool reuse - #1
Merged
bendangelo merged 2 commits intoAug 11, 2026
Merged
Conversation
bendangelo
marked this pull request as ready for review
August 11, 2026 18:35
Owner
|
Thank you for your contribution. |
Contributor
Author
|
@bendangelo |
Owner
|
No problem. I'm trying to test this out in a rails app but I've run into multiple issues, like the sqlite file staying locked. and that's preventing me from continuing work. I'm open to any other contributions. |
Contributor
Author
|
oops, are those issues caused by this PR? Yes, I'm interested in contributing to this gem and turso gem. |
Owner
|
No those were not caused by you. The issue is with the turso rust code, it's something I cannot touch. I'll keep testing this on my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
The
tursoRuby driver binds a native connection to the thread and fiber that created it. Active Record may safely check a pooled adapter back in and later lend that same adapter to another execution context. Reopening only the native connection during the checkout callback preserves Active Record's pooling contract without sharing a native connection across threads or fibers.Tests
bundle exec rake test(115 runs, 205 assertions)bundle exec rake test:conformance(37 runs, 63 assertions)