Repository navigation
use optional return types for fallible methods - #152
redraincatching wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pre-commit
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 24 to 25 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 29 to 30 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 34 to 35 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 39 to 40 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 44 to 45 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 49 to 50 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 76 to 77 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 96 to 99 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 105 to 106 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 114 to 131 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 142 to 143 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 145 to 146 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 148 to 149 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 151 to 152 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 154 to 155 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 157 to 158 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 170 to 171 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 174 to 175 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 178 to 179 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 182 to 183 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 186 to 187 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 190 to 191 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 194 to 195 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 198 to 199 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 202 to 203 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 206 to 207 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 210 to 211 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 214 to 215 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 218 to 219 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 226 to 227 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 233 to 235 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 238 to 239 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 243 to 245 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 262 to 271 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 274 to 276 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 280 to 286 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 295 to 750 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 752 to 780 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 782 to 785 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 787 to 788 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 790 to 792 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 799 to 811 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 818 to 819 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 822 to 823 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 825 to 827 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 831 to 832 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 834 to 836 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 842 to 843 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 848 to 849 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 855 to 856 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 862 to 863 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 865 to 867 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 873 to 874 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 876 to 878 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 887 to 888 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 894 to 896 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 900 to 902 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 904 to 910 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 914 to 917 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 919 to 925 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 932 to 933 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 935 to 939 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 950 to 951 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 953 to 958 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 961 to 963 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 974 to 975 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 977 to 982 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 985 to 987 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 996 to 1000 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1005 to 1009 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1020 to 1033 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1046 to 1047 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1062 to 1064 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1067 to 1069 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1073 to 1075 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1078 to 1080 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1083 to 1085 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1101 to 1103 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1105 to 1107 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1109 to 1110 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1112 to 1115 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1124 to 1130 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1135 to 1142 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1148 to 1155 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1160 to 1167 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1172 to 1179 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1184 to 1191 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1197 to 1203 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1208 to 1214 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1219 to 1225 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1230 to 1236 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1250 to 1251 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1253 to 1255 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1271 to 1272 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1274 to 1276 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1282 to 1288 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1297 to 1298 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1304 to 1305 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1311 to 1312 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1318 to 1319 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1325 to 1326 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1332 to 1333 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1339 to 1340 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1345 to 1346 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1350 to 1351 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1356 to 1357 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1363 to 1364 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1370 to 1371 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1377 to 1378 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1384 to 1385 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1391 to 1392 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1398 to 1399 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1405 to 1406 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1412 to 1413 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1419 to 1420 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1426 to 1427 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1433 to 1434 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1440 to 1442 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1448 to 1449 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1455 to 1457 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1463 to 1464 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1466 to 1467 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1472 to 1474 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1476 to 1477 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1502 to 1504 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1518 to 1922 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1928 to 1930 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1937 to 1939 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1944 to 1949 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1954 to 1959 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1964 to 1969 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1974 to 1980 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1985 to 1987 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 1992 to 1995 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 2001 to 2002 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 2008 to 2009 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 2013 to 2014 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 2018 to 2020 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 2023 to 2025 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 2028 to 2030 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 2032 to 2034 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 2037 to 2042 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 2047 to 2055 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 2061 to 2068 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 2078 to 2088 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 2106 to 2112 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 2116 to 2118 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 2124 to 2126 in 3108e69
[pre-commit] reported by reviewdog 🐶
inplace_vector/include/beman/optional/optional.hpp
Lines 2128 to 2140 in 3108e69
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
3108e69 to
cb2f400
Compare
| #ifndef BEMAN_OPTIONAL_DETAIL_STL_INTERFACES_FWD_HPP | ||
| #define BEMAN_OPTIONAL_DETAIL_STL_INTERFACES_FWD_HPP | ||
|
|
||
| #include <beman/optional/detail/stl_interfaces/config.hpp> |
There was a problem hiding this comment.
it's weird that there's a detail include from optional here....
There was a problem hiding this comment.
so I think the issue here is we're introducing a dependence on beman optional -- is that right?
There was a problem hiding this comment.
yes, the original issue suggested using beman optional so i decided to go along with that
there's every chance i've mishandled bringing int the dependency
| @@ -0,0 +1,85 @@ | |||
| // include/beman/optional/detail/stl_interfaces/fwd.hpp -*-C++-*- | |||
|
Thank you for your contribution, please allow some time to review. |
closes #119 by implementing p3981, using
beman.optionalas specified in the issue.