fix: apply review feedback to cmake.default check (PR #343)

[Copilot]

Addresses all review comments from the PR #343 review thread for the cmake.default check implementation.

Changes

cmake.py

• New check: CMakeDefaultCheck (cmake.default) — validates that the library target is built unconditionally in the root CMakeLists.txt
• Comment 4: Convert get_cmake_parse_tree() result to list() before passing to helper methods; the iterable would otherwise be exhausted on the first pass, silently mis-evaluating subsequent checks:

  # Before
  ast_tree = self.get_cmake_parse_tree()
  # After
  ast_tree = list(self.get_cmake_parse_tree())

• Comments 1 & 2: All type checks use isinstance(item, Command) — avoids fragile string-based type(x).__name__ comparisons
• Comment 3: fix() follows the established pattern (logs remediation guidance, returns False); fix-inplace test is @pytest.mark.skip(reason="not implemented"), consistent with all other checks in this file
• Add If and Option to cmake_parser.ast imports

Tests

• Import CMakeDefaultCheck in test_cmake.py
• Add test__cmake_default__valid, test__cmake_default__invalid, and test__cmake_default__fix_inplace (skipped)
• Add test fixtures: valid-default-v1.txt (unconditional library), invalid-default-v1.txt (library behind OFF option), invalid-default-v2.txt (library inside if(PROJECT_IS_TOP_LEVEL))

[Copilot]

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

[Copilot]

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.