Skip to content

fix: show the background re-login PIN to cloud users - #266

Closed
Fizzadar wants to merge 1 commit into
mainfrom
nick/visible-pin-prompt
Closed

Fizzadar wants to merge 1 commit into
mainfrom
nick/visible-pin-prompt

Conversation

@Fizzadar

Copy link
Copy Markdown
Contributor

The PIN for a silent password re-login was sent as a CONNECTING state, which the cloud status endpoint drops, so users never saw it and the re-login timed out. It is now sent as TRANSIENT_DISCONNECT with OPEN_NATIVE and the PIN in info so each new PIN gets through dedup, and CONNECTED is sent once it is confirmed.

🤖 Generated with Claude Code

The PIN for a silent password re-login was sent as a CONNECTING state,
which the status endpoint drops, so cloud users never saw it and the
re-login timed out.

Send it as TRANSIENT_DISCONNECT with OPEN_NATIVE and the PIN in Info so
each new PIN is delivered, and send CONNECTED once it is confirmed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@highesttt

Copy link
Copy Markdown
Collaborator

Unless I did something wrong, this should never happen 🤔

@Fizzadar

Copy link
Copy Markdown
Contributor Author

Unless I did something wrong, this should never happen 🤔

The fix is really about surfacing the error to the user (connecting will just be dropped). If we can drop the entire check even better?

@highesttt

Copy link
Copy Markdown
Collaborator

Unless I did something wrong, this should never happen 🤔

The fix is really about surfacing the error to the user (connecting will just be dropped). If we can drop the entire check even better?

The way LINE's login works, is if you have the certificate, you use that to relog, you dont need a PIN, so this should never show up unless the certificate is non existant (in the case of first-login), or something else went wrong and the certificate is invalid, in that case we have another issue 😅. So we can just use the certificate to relog.

@highesttt

highesttt commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

TL;DR users re-logging should already have the certificate stored, in that case we can use that to relog. A PIN is never needed in this specific scenario

@Fizzadar Fizzadar closed this Oct 14, 2026
@Fizzadar
Fizzadar deleted the nick/visible-pin-prompt branch October 14, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants