Skip to content

ci: require evidence behind every resolved review thread - #12

Merged
beejsbj merged 1 commit into
masterfrom
chore/review-evidence-gate
Oct 26, 2026
Merged

beejsbj merged 1 commit into
masterfrom
chore/review-evidence-gate

Conversation

@beejsbj

@beejsbj beejsbj commented Oct 26, 2026

Copy link
Copy Markdown
Owner

Why

An audit of every PR merged since June found 238 review findings that were still real problems on main. Almost all of them sat in threads nobody had replied to. When agents did resolve a thread, they were right 97% of the time, so the gap is silence, not false check-offs.

What

Adds a review-evidence check. A PR passes only when every review thread is resolved and each resolved thread has a reply with one of:

  • Fixed in <sha>: the commit has to exist in this repo, because Codex has cited SHAs that don't.
  • Declined: <reason>: also Not a bug:, Obsolete: or Duplicate:, with a reason of at least 20 characters.
  • Tracked in #<issue>: an open issue in this repo.

Resolving a thread doesn't trigger a workflow run. If you resolve without replying, the check stays red until a reply or a push re-runs it.

Where GitHub allows it, branch protection now requires conversations to be resolved before merging. After this merges, review-evidence can be added as a required status check.


Generated by Claude Code

Adds a review-evidence check: a PR passes only when every review thread is
resolved and each resolved thread has a reply naming an existing fix commit,
a reasoned decline, or a tracking issue.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JoNdqgz1ZvspS2otDVXCq3
@vercel

vercel Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dayshaper Ready Ready Preview Oct 26, 2026 10:16am UTC

@beejsbj
beejsbj marked this pull request as ready for review October 26, 2026 11:26
@beejsbj
beejsbj merged commit 888315a into master Oct 26, 2026
4 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch was successfully deployed

1 active deployment
Preview — eff217d4 Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant