Skip to content

Reconsider toResponse mapper in service layer #193

Description

@yamcodes

Clear and concise description of the problem

Arguably, toResponse mapping should be a controller-level concern, and the service layer should not be aware of it.

Suggested solution

Move all toResponse invocations to the controller layer.

Alternative

Leave the toResponse invocations where they are in the service layer, if we determine that the service layer should have knowledge of the desired API-level format.

Additional context

Consider our "project structure" and "architecture" docs.

Validations

  • Read the Contributing Guide.
  • Read the README.md.
  • Check that there isn't already an issue that requests the same feature.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions