fix: decode SubjectPublicKeyInfo without crypto.ecdsa's DER parser - #5
Merged
Merged
Conversation
Member
Author
what the hell is this 🤣 , impressive
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since V 414d5eb, crypto.ecdsa defaults to an mbedTLS backend that does not implement pubkey_from_bytes. Every identity assertion failed to verify, so a listener refused every client that sent one and a dialer couldn't verify the server token.
decode_public_key now takes the SubjectPublicKeyInfo apart itself, the reverse of encode_public_key and hands only the point to PublicKey.from_uncompressed_bytes which both backends implement and which checks the point is on the curve.