Repository navigation
fix: unify Facet dependency identity - #289
Merged
Merged
Conversation
fasterthanlime
enabled auto-merge
August 18, 2026 20:41
fasterthanlime
disabled auto-merge
August 18, 2026 20:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A clean
maincheckout cannot compiledodeca-protocol: Dodeca directly uses Facet from git revision5705fa6…, while Vox0.10.0-rc.5uses Facet0.50.0-rc.5from crates.io. Rust treats those as distinct trait identities, producing 84Facetbound errors.Change
Use the same crates.io Facet
0.50.0-rc.5identity as Vox and explicitly retainfacet-hash/jit, which Picante requires.Verification
cargo build --release --locked --bin ddcscripts/build-browser-assets.shDODECA_ASSETS_DIR=dist/dodeca-assets dist/ddc assets --packaged --faildist/ddcanddist/dodeca-assetscargo nextest run -E 'package(dodeca-protocol) | package(picante)'— 84 passed