Skip to content

Group member label support - #850

Open
Berglund wants to merge 3 commits into
bbernhard:masterfrom
Berglund:group-member-label-support
Open

Group member label support#850
Berglund wants to merge 3 commits into
bbernhard:masterfrom
Berglund:group-member-label-support

Conversation

@Berglund

@Berglund Berglund commented May 16, 2026

Copy link
Copy Markdown

I had a use-case for the new label (and emoji) feature in groups, and noted that signal-cli had support (AsamK/signal-cli@27a722d) but not signal-cli-rest-api.

If unaware of this functionality, it allows you to set a label for yourself in a group that's then visible for others:
image

This PR has three commits;

f07c587 adds support for setting the label via PUT /v1/groups/<number>/<group id> with member_label and member_label_emoji.

0938262 exposes the labels set in various groups on GET /v1/groups/<number>.

fc9a90c updates the public request interface based on review feedback, using the nested structure {"member_label": {"name": "<label>", "emoji": "<emoji>"}}.

@Berglund
Berglund marked this pull request as ready for review May 16, 2026 22:36
@Berglund
Berglund force-pushed the group-member-label-support branch from 0938262 to 26ca5fa Compare May 21, 2026 20:43
Comment thread src/api/api.go Outdated
Description *string `json:"description,omitempty"`
Name *string `json:"name,omitempty"`
MemberLabel *string `json:"member_label,omitempty"`
MemberLabelEmoji *string `json:"member_label_emoji,omitempty"`

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR!

In general I think the PR is fine. What I am unsure though is, the structure of the public interface. I think I'd prefer some like:

MemberLabel struct {
   Name      *string         `json:"name,omitempty"
   Emoji      *string         `json:"emoji,omitempty"`
} `json:"member_label,omitempty"`

What do you think?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! So sorry for the late response. Parental leave is taking the time it requires 😅

I like your suggestion! Took a stab at it in fc9a90c - see what you think.

@Berglund
Berglund force-pushed the group-member-label-support branch from 26ca5fa to fc9a90c Compare July 10, 2026 09:49
@Berglund
Berglund requested a review from bbernhard July 10, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants