Underline links and references on mouse hover#85
Merged
Conversation
The clickable references added the mouse-face highlight affordance, but a plain background swap. Add adoc-link-mouse-face (inherits highlight, adds an underline) and point the link/anchor/URL/include mouse-face at it, so hovering is more obviously actionable. Mirrors asciidoc-mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clickable-references work gave links a
mouse-face highlightaffordance, but that's just a background swap. This addsadoc-link-mouse-face(inheritshighlight, adds an underline) and points the link/anchor/URL/include mouse-face at it, so hovering reads as actionable.Mirrors the same change in asciidoc-mode, to keep the two modes consistent.