Repository navigation
Conversation
Add tests for nonce override precedence in MultisigScript.
Collaborator
🟡 Heimdall Review Status
|
Use a dedicated Safe address for the nonce override test so it does not mutate the shared SAFE_NONCE value used by other test fixtures.
Exercise the general override when present, preserve its parse error when malformed, and prove a distinct address-specific value takes precedence without mutating SAFE_NONCE shared by other tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SAFE_NONCE_{ADDRESS}), then general override (SAFE_NONCE), then fallback to on-chain Safe nonce.vm.envExistsso invalid parsing errors revert as expected rather than being silently ignored.test/universal/MultisigScript.t.solcovering Safe nonce fallback, general override, address-specific precedence, and revert on malformed override values. The test uses an isolated Safe mock and cleans up environment variables after execution.Fixes #443.
Validation
forge fmt --checkandgit diff --checkpass cleanly with zero whitespace or formatting issues.// nosemgrep: sol-safety-expectrevert-no-args.test_getNonce_envOverrides_followDocumentedPrecedenceto comprehensively verify all documented override and fallback paths.