Repository navigation
Fix documentation drift in architecture doc and AGENTS.md - #189
Merged
Merged
Conversation
Describe the implemented Gameplay setup slice, clarify which bounded contexts expose execute/handle routers, rename Move.execute to Movement.execute, and correct the handler return contract: internal handlers return effects while public routers commit and return Async<unit>, with Accounting's stateless skeleton as the exception. Refs #176
Align versions (Terminal.Gui 2.4.17, Expecto 11.1.0), file listings (Gameplay Handlers.fs, Rondel DirectCommit.fs), the handler return contract, command dispatch description, RondelView colors, test context pattern, and test coverage snapshot with the current code. Record the Terminal/Gameplay wiring gap tracked in #142 and drop the disabled merge-commit option. Refs #176
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the documentation-drift findings (F4) from the technical consistency audit in #176, plus a few additional stale spots found while verifying them.
docs/architecture.mdexecute/handle, while Accounting exposes onlyexecute.Move.executetoMovement.execute.Async<unit>; Accounting's stateless skeleton is noted as the exception.AGENTS.md2.4.17, Expecto11.1.0.Handlers.fs, RondelDirectCommit.fs;mkAttrattributed toRondelView.fs.RondelDirectCommitsequential dispatch instead ofList.fold/Result.bind.Context+SpecRunner.emptypattern.Move.executerenamed in the section-order table.DirectCommitTests.fsadded to the coverage snapshot.Refs #176