Make filament manager notes searchable - #11505
Merged
lanewei120 merged 1 commit intoJul 22, 2026
Merged
Conversation
Contributor
Author
|
Closing as duplicate of #11484, which already covers making filament manager notes searchable. |
Contributor
Author
|
Reopened this PR because #11484 was closed as the older duplicate. This PR contains the current clean implementation. |
Collaborator
|
thanks @BenJule |
MackBambu
pushed a commit
to MackBambu/BambuStudio
that referenced
this pull request
Aug 14, 2026
内部reviewer: 青松 github pull request: bambulab#11505 Change-Id: I8e22ccb8ee35dd8015aefb558e53630a53101a97 (cherry picked from commit 745cabfffec21f1635135d75bc6c747111e0bc46)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes filament manager notes searchable.
Why
The filament manager search currently matches brand, filament type, material series, and color name, but ignores the note field.
This makes it hard to find spools using user-provided labels such as storage location, project names, purchase notes, or custom descriptions.
Implementation
spoolSearchText()helper.spool.notein the searchable text.Test plan