Skip to content

Make filament manager notes searchable - #11505

Merged
lanewei120 merged 1 commit into
bambulab:masterfrom
BenJule:feature/filament-manager-note-search
Jul 22, 2026
Merged

Make filament manager notes searchable#11505
lanewei120 merged 1 commit into
bambulab:masterfrom
BenJule:feature/filament-manager-note-search

Conversation

@BenJule

@BenJule BenJule commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR makes filament manager notes searchable.

Why

The filament manager search currently matches brand, filament type, material series, and color name, but ignores the note field.

This makes it hard to find spools using user-provided labels such as storage location, project names, purchase notes, or custom descriptions.

Implementation

  • Adds a small spoolSearchText() helper.
  • Includes spool.note in the searchable text.
  • Trims the search keyword before matching.
  • Keeps the existing brand/type/series/color-name search behavior.

Test plan

  • Add or edit a filament spool with a note.
  • Search for a word that only appears in the note.
  • Confirm the spool appears in the filtered list.
  • Search for brand, filament type, material series, or color name and confirm existing behavior still works.

@BenJule

BenJule commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #11484, which already covers making filament manager notes searchable.

@BenJule BenJule closed this Jul 10, 2026
@BenJule BenJule reopened this Jul 10, 2026
@BenJule

BenJule commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Reopened this PR because #11484 was closed as the older duplicate. This PR contains the current clean implementation.

@lanewei120
lanewei120 merged commit 2daae24 into bambulab:master Jul 22, 2026
32 of 39 checks passed
@lanewei120

Copy link
Copy Markdown
Collaborator

thanks @BenJule

MackBambu pushed a commit to MackBambu/BambuStudio that referenced this pull request Aug 14, 2026
内部reviewer: 青松

github pull request: bambulab#11505

Change-Id: I8e22ccb8ee35dd8015aefb558e53630a53101a97
(cherry picked from commit 745cabfffec21f1635135d75bc6c747111e0bc46)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants