Skip to content

Add copy button to generic error dialog - #11498

Open
BenJule wants to merge 2 commits into
bambulab:masterfrom
BenJule:feature/copy-error-dialog-message
Open

Add copy button to generic error dialog#11498
BenJule wants to merge 2 commits into
bambulab:masterfrom
BenJule:feature/copy-error-dialog-message

Conversation

@BenJule

@BenJule BenJule commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR adds a non-closing Copy button to the generic ErrorDialog.

Why

Error dialogs often contain details that are useful for bug reports or support requests. A dedicated copy button makes it easier for users to copy the exact error text instead of taking screenshots or manually retyping it.

Related to #11497

Implementation

  • Extend MsgDialog::add_button(...) with an optional end_modal argument.
  • Keep the default behavior unchanged for existing callers.
  • Add a Copy button to ErrorDialog.
  • The copy button writes the stored error message to the clipboard and keeps the dialog open.

Scope

This PR only affects the generic ErrorDialog.

It does not:

  • add copy buttons to all message dialogs
  • change warning, confirmation, or question dialogs
  • change error handling behavior
  • change the existing OK button behavior

Test plan

  • Trigger or instantiate an ErrorDialog.
  • Confirm the dialog shows both OK and Copy.
  • Click Copy.
  • Confirm the error text is copied to the clipboard.
  • Confirm the dialog stays open after clicking Copy.
  • Click OK.
  • Confirm the dialog closes normally.

@BenJule
BenJule force-pushed the feature/copy-error-dialog-message branch from d2eeacb to 5ef059d Compare July 10, 2026 16:02

@Haidiye00 Haidiye00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please record the effect after the changes, thanks.

@Haidiye00 Haidiye00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please submit the GIF recording, and merge the patches into one. Thanks.

@BambulabRobot
BambulabRobot requested review from Haidiye00 and bambu123 and removed request for milk-pure and walterwongbbl July 21, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants