Repository navigation
abstract weston.ini configuration to display domain variables - #8
Merged
Merged
Conversation
Contributor
Author
Testsusing DISPLAY_* env vars: 1.
2.
3.
|
rahul-thakoor
force-pushed
the
abstract-display-configuration
branch
from
June 4, 2026 14:56
a2103ec to
7adcb9d
Compare
chrisys
suggested changes
Jun 4, 2026
| | `WESTON_INI_CORE_REQUIRE_INPUT` | `true`, `false` | `false` | Dictates whether Weston requires an active input device to launch. false permits display-only deployments. | | ||
| | `WESTON_INI_SHELL_LOCKING` | `true`, `false` | `false` | Enables or disables screen locking functionality within the shell context. | | ||
| | `WESTON_INI_SHELL_PANEL_POSITION` | `top`, `bottom`, `left`, `right`, `none` | `none ` | Sets the location of the desktop panel. none disables the panel entirely, ensuring an unobstructed viewport. | | ||
| | `WESTON_INI_PATH` | Absolute path to a custom `weston.ini` file | - | When this variable is set and the file is present, Weston will be luanched directly using the provided file. Consequently any other `DISPLAY_*` environment variables defined for the container will be ignored. | |
Contributor
There was a problem hiding this comment.
Suggested change
| | `WESTON_INI_PATH` | Absolute path to a custom `weston.ini` file | - | When this variable is set and the file is present, Weston will be luanched directly using the provided file. Consequently any other `DISPLAY_*` environment variables defined for the container will be ignored. | | |
| | `WESTON_INI_PATH` | Absolute path to a custom `weston.ini` file | - | When this variable is set and the file is present, Weston will be launched directly using the provided file. Consequently any other `DISPLAY_*` environment variables defined for the container will be ignored. | |
This decouples the block's public configuration interface from Weston-specific implementation details, ensuring fleet variables remain stable and compositor-agnostic even if the underlying display server changes in the future. Some values are still Weston-specific, but this is a step towards a more flexible and maintainable configuration system. We also restrict supported DISPLAY_UX_MODE values to 'kiosk' and 'desktop' (upstream 'fullscreen' shell is deprecated; 'ivi' is out of scope) Change-type: minor Signed-off-by: Rahul Thakoor <rahul@balena.io>
rahul-thakoor
force-pushed
the
abstract-display-configuration
branch
from
June 4, 2026 15:07
7adcb9d to
e09e980
Compare
chrisys
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This decouples the block's public configuration interface from Weston-specific implementation details, ensuring fleet variables remain stable and compositor-agnostic even if the underlying display server changes in the future. Some values are still Weston-specific, but this is a step towards a more flexible and maintainable configuration system.
Change-type: minor