chore: fix unity tests windows#294
Conversation
…ow processed if scoped attributes don't exist
melekr
left a comment
There was a problem hiding this comment.
Nice cleanup. The platform specific skips look appropriate: Android stack trace parsing is compiled only for Android/Editor and the DisableInEditor assertions are editor only by design.
One small suggestion: GetScopedAttributes()now reads legacy PlayerPrefs attributes even when the scoped key list is missing, but the legacy migration path deletes those old PlayerPrefs keys without calling PlayerPrefs.Save(). Since this is part of the Windows startup/minidump flow, an explicit save after deleting legacy keys would make the cleanup deterministic and avoid relying on a later PlayerPrefs flush.
Maybe worth adding PlayerPrefs.Save() at the end of ScopedNativeAttributesTests.CleanState() after PlayerPrefs.DeleteAll() in Player test runs?
Summary
Fixes failing unity tests on windows.
Changes
TODO
ref: BT-7113