Skip to content

chore: fix unity tests windows#294

Draft
KishanPRao wants to merge 3 commits into
masterfrom
chore/fix-unity-tests-windows
Draft

chore: fix unity tests windows#294
KishanPRao wants to merge 3 commits into
masterfrom
chore/fix-unity-tests-windows

Conversation

@KishanPRao

Copy link
Copy Markdown

Summary

Fixes failing unity tests on windows.

Changes

TODO

ref: BT-7113

@KishanPRao KishanPRao requested a review from melekr July 2, 2026 14:24
@KishanPRao KishanPRao self-assigned this Jul 2, 2026

@melekr melekr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. The platform specific skips look appropriate: Android stack trace parsing is compiled only for Android/Editor and the DisableInEditor assertions are editor only by design.

One small suggestion: GetScopedAttributes()now reads legacy PlayerPrefs attributes even when the scoped key list is missing, but the legacy migration path deletes those old PlayerPrefs keys without calling PlayerPrefs.Save(). Since this is part of the Windows startup/minidump flow, an explicit save after deleting legacy keys would make the cleanup deterministic and avoid relying on a later PlayerPrefs flush.

Maybe worth adding PlayerPrefs.Save() at the end of ScopedNativeAttributesTests.CleanState() after PlayerPrefs.DeleteAll() in Player test runs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants