feature: support more than 64 native attributes#293
Draft
KishanPRao wants to merge 1 commit into
Draft
Conversation
rick-bt
approved these changes
Jun 16, 2026
Author
|
KishanPRao
changed the title
melekr
reviewed
Jul 3, 2026
melekr
left a comment
melekr
left a comment
Collaborator
There was a problem hiding this comment.
to be updated with changes from : https://gitlab.tools.saucelabs.net/saucelabs/error-reporting/product/backtrace-unity-windows-native/-/merge_requests/1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the 64-entry limit on native (Crashpad) attributes.
Previously, a simple dictionary was used for storing attributes, which limits the total count to 64 entries. They are now stored in Crashpad's global
AnnotationList.The attribute count is limited by Crashpad's internal limit,
kMaxNumberOfAnnotations.SetAnnotationwill refuse to add keys beyond the limit, providing feedback with a warning.Changes
ref: BT-6868