Skip to content

feat: support loopback redirect for desktop OAuth + auto-allow users - #293

Merged
azimjohn merged 1 commit into
azimjohn:masterfrom
mabrur-h:feature/obtain-token-for-macapp
Apr 28, 2026
Merged

feat: support loopback redirect for desktop OAuth + auto-allow users#293
azimjohn merged 1 commit into
azimjohn:masterfrom
mabrur-h:feature/obtain-token-for-macapp

Conversation

@mabrur-h

Copy link
Copy Markdown
Collaborator
  • /auth now accepts a callback query param; after GitHub OAuth the token is appended to that URL so the desktop app can capture it via a 127.0.0.1 listener (RFC 8252) instead of a custom protocol.
  • Use net/url to merge ?token= into the callback so existing query params (e.g. state for CSRF) are preserved.
  • Auto-add freshly authenticated GitHub users to allowed-users.csv so desktop sign-ins work without manual invites.
  • Reload the allow-list every 5s instead of every minute so newly added users can tunnel almost immediately after sign-in.

@azimjohn
azimjohn merged commit b1dd7ce into azimjohn:master Apr 28, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants