feat(workflows): add goreleaser - #748
stauersbol wants to merge 32 commits into
Conversation
|
looks like i forgot to setup signed commits, will have to do that |
429b3d7 to
92c1ab9
Compare
|
should all be signed now after amending them |
|
yep that was the plan to use, didnt have time to look into it yesterday, plan is doing so day. |
d48b9c7 to
7777ada
Compare
e9fa87d to
1a3fd16
Compare
|
@ayn2op need you opinion on some bits, ive added comments to what im unsure about. for the most part dry-run works. I believe there is still some configuration left and I might just nuke the custom name templating I did, as it makes the life of packagers easier on AUR and such. |
|
I might also consider adding linux arm64 and arm64hf (in case pi users would like to use it) |
|
alright touched the points you had @ayn2op, i also went ahead to add linux arm64 and armv7 build targets, since it could be relevant if some users of those 2 ISAs appear. |
|
Though there is something with how changelog works, unsure how it works under CI conditions, but it may overwrite any auto generated changelog notes on a release, but it might be worth the initial try and then adjust if it does indeed overwrite |
b53f8e1 to
302eae2
Compare
|
simplified the build targets in the config and also added some docs in the readme that describes goreleaser |
da1ce3a to
51c31b7
Compare
5bbbf25 to
c79b4be
Compare
|
Alright finally got time to clean up a little. I removed a merge commit, as they tend to not be good for git history. I have removed the @ayn2op ready for whenever you choose to look at this again, no rush on your end of cource :) EDIT: note to a potential nit, I left a static variable in the Makefile as it might be relevant if we chose, before merging this, to just set a version of goreleaser-cross and then update with small PRs down the line, open for both, left it on |
|
@ayn2op im guessing we still need to use |
Signed-off-by: Lukas Stauersbøl <9026132+stauersbol@users.noreply.github.com>
|
fixed a merge conflict |
| - name: release publish | ||
| run: | | ||
| docker run \ | ||
| --rm \ | ||
| -e 'GITHUB_TOKEN=${{secrets.GITHUB_TOKEN}}' \ | ||
| -v /var/run/docker.sock:/var/run/docker.sock \ | ||
| -v `pwd`:/go/src/github.com/ayn2op/discordo \ | ||
| -w /go/src/github.com/ayn2op/discordo \ | ||
| ghcr.io/goreleaser-cross:latest \ | ||
| release --clean |
There was a problem hiding this comment.
Like previously stated, discordo no longer relies on CGO to compile, so goreleaser-cross setup can be completely removed.
There was a problem hiding this comment.
ah woops my bad, will adjust later today
There was a problem hiding this comment.
I'd recommend running goreleaser init again and going from there.
2 participants
Simply adds goreleaser, there is a bunch of defaults and some things are locked behind their pro plan, but might not be necessarily useful things.
There could be some debate on the
.goreleaser.yamlconfig file, but I'm all ears on that part.It defaults to prerelease as this was a request from ayyan.
Feel free to go read through the docs at: https://goreleaser.com/customization/