Repository navigation
feat: log Safe EIP-712 tx hashes on cheat broadcast - #180
Merged
Merged
Conversation
When the broadcast sender is a Safe wallet, cheatBroadcast only logs and pranks instead of sending. Add Domain Hash, Message Hash, and Safe Tx Hash to that log so signers can independently verify before signing. Nonce resolution priority: overwrite (env SAFE_NONCE) > Safe Transaction Service API (queue-aware) > on-chain Safe.nonce(). The API base URL maps chainId 2020 to the Ronin service and is overridable via SAFE_TX_SERVICE_URL. Hash math is extracted to a pure computeSafeTxHashes() and verified against independently cast-derived reference values in test/SafeTxHashes.t.sol. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
When the broadcast sender is a Safe wallet, cheatBroadcast only logs and pranks instead of sending. Add Domain Hash, Message Hash, and Safe Tx Hash to that log so signers can independently verify before signing. Safe detection trusts the Safe Transaction Service (HTTP 200), falling back to an on-chain singleton check (proxy slot 0 vs known Safe singletons) when the service is unavailable (testnet/localhost, unmapped chain, or offline). Nonce resolution priority: overwrite (env SAFE_NONCE) > Safe Transaction Service API (queue-aware) > on-chain Safe.nonce(). The API base URL maps chainId 2020 to the Ronin service and is overridable via SAFE_TX_SERVICE_URL. Hash math is extracted to a pure computeSafeTxHashes() and verified against independently cast-derived reference values in test/SafeTxHashes.t.sol. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Removed duplicate logSafeTxHashes call before executing the transaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the broadcast sender is a Safe wallet, cheatBroadcast only logs and pranks instead of sending. Add Domain Hash, Message Hash, and Safe Tx Hash to that log so signers can independently verify before signing.
Nonce resolution priority: overwrite (env SAFE_NONCE) > Safe Transaction Service API (queue-aware) > on-chain Safe.nonce(). The API base URL maps chainId 2020 to the Ronin service and is overridable via SAFE_TX_SERVICE_URL.
Hash math is extracted to a pure computeSafeTxHashes() and verified against independently cast-derived reference values in test/SafeTxHashes.t.sol.
Description
Checklist