fix(runtime): update shell session wire protocol - #249
Open
priyasingh2111 wants to merge 1 commit into
Open
Conversation
priyasingh2111
requested a deployment
to
manual-approval
August 11, 2026 18:29 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify shell session connection and lifecycle to improve performance and align with updated server behavior.
Changes:
close()now detaches instead of terminating — closing the session disconnects the WebSocket but leaves the shell alive on the server, enabling reconnection within the reconnect window.shell.reconnectedandshell.bytesDroppedproperties — these are no longer available. TypeScript will report a compile error if accessed.onReconnectcallback signature — now() => void | Promise<void>(no arguments).Exit codes, auto-reconnect, and all other shell functionality continue to work as before.
Related Issues
Documentation PR
Type of Change
Breaking change
Breaking Changes
shell.reconnected— removed (wasboolean)shell.bytesDropped— removed (wasnumber)onReconnectcallback signature:(reconnected: boolean) => void→() => void | Promise<void>close()no longer terminates the shell — it detaches, allowing reconnectionTesting
npm run checknpm test— 616 tests pass (24 files), 1.13snpm run lint— cleannpm run format:check— cleannpm run type-check— cleanChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.