.NET Framework compatibility update - #318
Conversation
sliedig
changed the title
|
|
||
|
|
||
| #if NETFRAMEWORK | ||
| #if !NET8_0 |
There was a problem hiding this comment.
Why is NET8_0 excluded for the test? What about NET9_0?
|
|
||
| aws cloudwatch put-metric-data \ | ||
| --metric-name "$METRIC_NAME" \ | ||
| --dimensions "failure=rate,framework=${{matrix.version}},os=${{matrix.os}}" \ |
There was a problem hiding this comment.
It is great to get clearer information with more metrics dimensions. However, CloudWatch metrics treat different set of dimensions as different time series data. Please also publish old metrics to keep backward compatibility.
|
|
||
| aws cloudwatch put-metric-data \ | ||
| --metric-name "$METRIC_NAME" \ | ||
| --dimensions "failure=rate,framework=${{matrix.version}},os=${{matrix.os}}" \ |
There was a problem hiding this comment.
Same metrics dimension issue as above.
| dotnet --list-runtimes | ||
|
|
||
| # Verify required SDKs are installed | ||
| if ! dotnet --list-sdks | grep -q "3.1"; then |
There was a problem hiding this comment.
The workflow failed at this line.
https://github.com/aws/aws-xray-sdk-dotnet/actions/runs/16819664570/job/47853319101?pr=318
| exit 1 | ||
| fi | ||
|
|
||
| if ! dotnet --list-sdks | grep -q "8.0"; then |
There was a problem hiding this comment.
Same as above. This line might fail in workflow run.
There was a problem hiding this comment.
Not sure why this workflow requires any change.
2 participants
Issue #, if available: #315
Description of changes:
Overview
This PR updates the AWS X-Ray Recorder SDK for .NET to support the latest recommended target frameworks while maintaining backward compatibility. The changes align with current Microsoft support policies and provide users with access to the latest performance improvements and security updates.
Target Framework Changes
Key Updates:
✅ Upgraded .NET 6.0 → .NET 8.0 (latest LTS version)
✅ Upgraded .NET Framework 4.62/4.5 → .NET Framework 4.8.1 (latest supported version)
✅ Maintained .NET Core 3.1 for backward compatibility
✅ Maintained .NET Standard 2.0 for broad ecosystem support
✅ Updated the GitHub build system to match new targets.
Technical Changes
Conditional Compilation Updates
Package Reference Updates
File Exclusion Logic
Breaking Changes
None - This is a non-breaking change that maintains full backward compatibility while adding support for newer frameworks.
Benefits
🚀 Performance: Access to .NET 8.0 performance improvements and optimizations
🔒 Security: Latest security patches and updates from .NET 8.0 and .NET Framework 4.8.1
🛠️ Developer Experience: Support for latest C# language features and tooling
📦 Future-Proof: Alignment with Microsoft's current support lifecycle
🔄 Compatibility: Maintains support for existing applications on older frameworks
Migration Path
Existing applications can continue using the library without any code changes. To take advantage of the new target frameworks:
Justification for removing unsupported frameworks
I removed unsupported targets (e.g., net452, net462, netcoreapp2.0, net6.0) to align with Microsoft support, reduce security risk and CI instability, and focus maintenance on platforms that receive fixes. The SDK now targets net8.0, netcoreapp3.1, netstandard2.0, and net481; netstandard2.0 preserves broad compatibility for many older apps. If you can’t upgrade yet, please pin to a previous SDK release. This shift improves performance, reliability, and security for supported platforms.
This update ensures the AWS X-Ray Recorder SDK stays current with Microsoft's supported frameworks while maintaining the stability and compatibility that existing users depend on.
Additionally, no new functionality has been introduced. This is primarily a compatibility update with modern frameworks. New functionality will be focused on OTel.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.