fix: strip path root correctly in partition extraction - #3418
Open
hsusul wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
_extract_partitions_from_pathinawswrangler/_arrow.pywheref"{path_root}/"was evaluated on apath_rootvariable that was already normalized to end with a trailing slash (/).f"{path_root}/"resulted in a double trailing slash (//), causingpath_wo_filename.replace(f"{path_root}/", "")to fail silently and returnpath_wo_filenameunstripped.path_rootcontained any directory or bucket segment with an=(e.g.s3://bucket/env=dev/table/),_extract_partitions_from_pathincorrectly parsedenv=devas a dataset partition column ({'env': 'dev', 'year': '2023'}instead of{'year': '2023'})..replace(...)withremoveprefix(...)across partition and copy path resolution functions (_arrow.py,s3/_read.py,s3/_copy.py) to safely strip prefixes without side effects.test_utils.pyand a moto test intest_moto.py.Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.