Skip to content

test(middleware-sdk-s3): use crypto.randomUUID for E2E test bucket names #8088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trivikr merged 1 commit into from
Jun 9, 2026
Merged

test(middleware-sdk-s3): use crypto.randomUUID for E2E test bucket names #8088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 3 additions & 19 deletions ...dk-s3/src/submodules/s3/middleware-region-redirect/region-redirect-middleware.e2e.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import type { S3ClientConfig } from "@aws-sdk/client-s3";
import { S3, waitUntilBucketExists, waitUntilBucketNotExists } from "@aws-sdk/client-s3";
import type { GetCallerIdentityCommandOutput } from "@aws-sdk/client-sts";
import { STS } from "@aws-sdk/client-sts";
import { S3, waitUntilBucketExists } from "@aws-sdk/client-s3";
import { afterAll, beforeAll, describe, expect, onTestFailed, test as it } from "vitest";

const testValue = "Hello S3 global client!";
Expand Down Expand Up @@ -30,32 +28,18 @@ describe("S3 Global Client Test", () => {
return config;
});
const s3Clients = regionConfigs.map((config) => new S3(config));
const stsClient = new STS({});

let callerID = null as unknown as GetCallerIdentityCommandOutput;
let bucketNames = [] as string[];

// random element limited to 2 letters to avoid concurrent IO, and
// to limit bucket count to 676 if there is failure to delete them.
const alphabet = "abcdefghijklmnopqrstuvwxyz";
const randId = alphabet[(Math.random() * alphabet.length) | 0] + alphabet[(Math.random() * alphabet.length) | 0];

beforeAll(async () => {
callerID = await stsClient.getCallerIdentity({});
bucketNames = regionConfigs.map((config) => `${callerID.Account}-${randId}-redirect-${config.region}`);
await Promise.all(
bucketNames.map(async (bucketName, index) => {
await deleteBucket(s3Clients[index], bucketName);
return waitUntilBucketNotExists({ client: s3Clients[index], maxWaitTime: 60 }, { Bucket: bucketName });
})
);
const uniqueId = crypto.randomUUID();
bucketNames = regionConfigs.map((config) => `redirect-${config.region}-${uniqueId}`);
Comment thread
trivikr marked this conversation as resolved.
await Promise.all(
bucketNames.map(async (bucketName, index) => {
await s3Clients[index].createBucket({ Bucket: bucketName });
return waitUntilBucketExists({ client: s3Clients[index], maxWaitTime: 60 }, { Bucket: bucketName });
})
);
await Promise.all(bucketNames.map((bucketName, index) => s3Clients[index].headBucket({ Bucket: bucketName })));
}, 60_000);

afterAll(async () => {
Expand Down
Loading