feat(lib-transfer-manager): add @aws-sdk/lib-transfer-manager as private package - #8074
Merged
Conversation
smilkuri
marked this pull request as draft
June 4, 2026 18:27
smilkuri
marked this pull request as ready for review
June 4, 2026 18:59
smilkuri
force-pushed
the
private-tm
branch
3 times, most recently
from
June 5, 2026 14:22
bacc1a7 to
6751f33
Compare
kuhe
reviewed
Jun 5, 2026
kuhe
reviewed
Jun 5, 2026
kuhe
reviewed
Jun 5, 2026
kuhe
reviewed
Jun 5, 2026
kuhe
reviewed
Jun 5, 2026
kuhe
reviewed
Jun 5, 2026
| "browser": { | ||
| "./dist-es/runtimeConfig": "./dist-es/runtimeConfig.browser", | ||
| "./dist-es/s3-transfer-manager/join-streams": "./dist-es/s3-transfer-manager/join-streams.browser", | ||
| "./dist-es/s3-transfer-manager/worker-http-handler": "./dist-es/s3-transfer-manager/worker-http-handler.browser", |
Contributor
There was a problem hiding this comment.
rather than file level replacements, create a separate index.browser.ts file.
main: dist-cjs/index.js
browser: dist-es/index.browser.js
module: dist-es/index.browser.js
react-native: dist-es/index.native.js
Contributor
Author
There was a problem hiding this comment.
For this we need to duplicate S3TransferManager.ts into S3TransferManager.browser.ts and replace join-streams and worker-http-handler browser variants in the imports. Is it worth duplicating the code?
Contributor
There was a problem hiding this comment.
use dependency injection binding like in https://github.com/smithy-lang/smithy-typescript/blob/main/packages/core/src/submodules/serde/index.browser.ts
export class Uint8ArrayBlobAdapter extends bindUint8ArrayBlobAdapter(toUtf8, fromUtf8, toBase64, fromBase64) {}
kuhe
reviewed
Jun 5, 2026
kuhe
reviewed
Jun 5, 2026
smilkuri
force-pushed
the
private-tm
branch
3 times, most recently
from
June 8, 2026 15:02
24c9863 to
360ad75
Compare
kuhe
reviewed
Jun 8, 2026
kuhe
approved these changes
Jun 8, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a work in progress high level library to interact with S3 which provides support for multipart upload using worker threads.
Testing
Checklist
*.integ.spec.ts) or E2E tests.@public,@internaltags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.