fix(lib-storage): avoid forwarding object-level params to UploadPart - #8042
Closed
danyalahmed1995 wants to merge 1 commit into
Closed
fix(lib-storage): avoid forwarding object-level params to UploadPart#8042danyalahmed1995 wants to merge 1 commit into
danyalahmed1995 wants to merge 1 commit into
Conversation
4 tasks
8 tasks
Author
|
@aBurmeseDev If the original issue is resolved should i close this PR or you would like to do it ? |
Author
|
Closing as the original issue #8020 was resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #8020
Description
This narrows the params passed to
UploadPartCommandin multipartUploadso object-levelUploadparams are not forwarded into every part upload.The multipart path now avoids copying fields such as
IfNoneMatch,ContentType,ContentMD5, and concrete user-suppliedChecksum*values intoUploadPartCommand.ChecksumAlgorithmis still passed through so the SDK checksum middleware can compute checksums for the actual part body.This also keeps the single-part
PutObjectCommandpath unchanged, so object-level params are still preserved when the upload does not use multipart.Related to #8029. This follows the same
UploadPartCommandboundary issue, but also excludes concrete user-suppliedChecksum*values from multipart part requests.Testing
Added regression coverage for:
PutObjectCommandpreserving object-level paramsUploadPartCommandnot receiving object-level headers/checksum valuesUploadPartCommandCompleteMultipartUploadCommandstill receivingIfNoneMatchRan:
Also verified locally with a custom request handler using the real
S3Clientserializer path. MultipartUploadPartrequests no longer carried the object-level conditional/checksum headers, while the singlePutObjectpath still preserved them.Checklist
*.integ.spec.ts) or E2E tests.@public,@internaltags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.