fix: prevent unhandled credential prefetch rejections - #900
Open
tamazonian wants to merge 3 commits into
Open
tamazonian wants to merge 3 commits into
tamazonian wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change
I saw
InvalidTokenErrorin a web application's error logs. I traced it to the function RUM uses to get AWS credentials, rather than the application's own code.RUM calls that function early, in
setAwsCredentials(), so credentials are ready before the page closes. But it ignores the returned promise. If the request fails, the browser reports an unhandled error that other error loggers can pick up.I reproduced this in
aws-rum-web 3.2.1using a function that always fails. The problem also happens with a plainError, not justInvalidTokenError.What the fix does
Catch the failed early request and log a warning when debug logging is on:
The warning does not include the original error or credential details. RUM still uses the same credential function for later requests. This does not fix AWS access or recover lost monitoring data.
Promise.resolvekeeps existing JavaScript callers working when they return credentials directly or an object with athenmethod. Errors thrown immediately by the function are unchanged.Try it
Both pages run the same test. The first uses the released SDK; the second uses this proposed fix. No monitoring data is sent.
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.