-
Notifications
You must be signed in to change notification settings - Fork 41
Feat: Add prompt caching to bedrock models #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sQu4rks
wants to merge
2
commits into
aws-devtools-labs:main
Choose a base branch
from
sQu4rks:feat/bb-agent-prompt-caching
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| --- | ||
| "@aws-blocks/bb-agent": minor | ||
| --- | ||
|
|
||
| feat(bb-agent): opt-in Bedrock prompt caching via `ModelConfig.cacheConfig` | ||
|
|
||
| Agents can now enable Strands prompt caching for the `bedrock` provider by | ||
| setting `cacheConfig: { strategy: 'auto' | 'anthropic' }` on a model config. | ||
| Caching reuses the cached request prefix (tools + system prompt + prior turns) | ||
| across requests, cutting input-token cost and latency for agents with long | ||
| system prompts, many tools, or multi-turn conversations. | ||
|
|
||
| Off by default and additive — existing configs are unaffected. Use | ||
| `'auto'` for the `BedrockModels` presets (Strands places cache points for | ||
| known model IDs) and `'anthropic'` when `modelId` is an ARN application | ||
| inference profile that `'auto'` can't detect. Ignored by the `openai-api` | ||
| and `canned` providers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happen if the strategy is 'anthropic' but the model id is not anthropic? Shall we place a check on modelId for this strategy?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments @Simone319
I believe the
strategy: anthropicis specifically designed for cases where - from the ARN - it's unclear that the underlying model is an anthropic model. The ARN could look something like thisarn:aws:bedrock:{region}:{account-number}:inference-profile/my-team-profile(docs) so we'd need another API call (and accompanying permissions) to retrieve the underlying model (viaGetInferenceProfile(api docs) to then parse the models.I also checked the case quickly via a script (see below). Since
cacheConfigis passed to the StrandsBedrockModelit's behavior is entirely strands.With
strategy: 'anthropic'on a non-Anthropic model, Strands forwards the Anthropic-style cache points and Bedrock rejects the request with a clearModelError("You invoked an unsupported model or your request did not allow prompt caching").So my suggestion would be to handle the warnings/errors but let Bedrock do the verification.