Skip to content

fix: isolate cookie-aware binary HTTP tests (ticket-017) - #33

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/017-binary-http-test-isolation
Oct 1, 2026
Merged

ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/017-binary-http-test-isolation

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

The classic HTTP interpreter now uses a cookie-aware urllib opener, but the binary response fixture patched only urlopen. Mock both boundaries so PNG/PDF evidence tests remain isolated and do not contact example.invalid. Product behavior remains unchanged.

Validation: 20 focused binary, SSL/cookie and optional-unreachable tests passed; managed governance passed with zero errors and warnings. Scoped ticket-017 uses a managed Worktrees v5 checkout. Publication requires independent Validator review and green CI for the exact head.

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head b2de7a15ff0a632e2d2ebc24eddc1085a8a29735.

Ticket: ticket-017
Correlation ID: local-autogrammar-testql-pr-33-ticket-017
Model: zai/glm-5.3
Advisory LLM review: LLM_UNAVAILABLE
Reason: litellm.APIError: APIError: OpenrouterException - {"error":{"message":"Insufficient credits. Add more using https://openrouter.ai/settings/credits","code":402,"metadata":{"limit_source":"openrouter_credits","remedy_hint":"Add credits at https://openrouter.ai/settings/credits, or lower max_tokens / prompt size to fit your remaining balance."}}}
This approval rests on the deterministic checks alone; no advisory opinion was recorded for this head.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 74f5141237eff330f169d4791a79d38874ff4c73...b2de7a15ff0a632e2d2ebc24eddc1085a8a29735
Change digest: 59d62049beda1d8e44dbfc5c3c89f4d50e0792b17ec62b5743073e47f7cb9e5a
Score: 52/100 (M), estimated 57 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":113,"base_sha":"74f5141237eff330f169d4791a79d38874ff4c73","binary_files":0,"categories":{"configuration":1,"docs":3,"tests":1},"change_digest":"59d62049beda1d8e44dbfc5c3c89f4d50e0792b17ec62b5743073e47f7cb9e5a","comparison":"74f5141237eff330f169d4791a79d38874ff4c73...b2de7a15ff0a632e2d2ebc24eddc1085a8a29735","deletions":0,"file_count":5,"files":["project/TICKETS.md","project/ticket-017/README.md","project/ticket-017/ai-codex.md","project/ticket-017/intent.json","tests/test_api_binary_responses.py"],"head_sha":"b2de7a15ff0a632e2d2ebc24eddc1085a8a29735","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":2,"scope":3,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":57,"within_budget":false},"impact":{"components":["PNG","SSL","project","tests"],"files":["PNG/PDF","SSL/cookie","project/TICKETS.md","project/ticket-017/README.md","project/ticket-017/ai-codex.md","project/ticket-017/intent.json","tests/test_api_binary_responses.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":52,"split":{"parts":[{"estimated_minutes":12,"name":"Implement PNG","scope":["PNG"]},{"estimated_minutes":12,"name":"Implement SSL","scope":["SSL"]},{"estimated_minutes":12,"name":"Implement project","scope":["project"]},{"estimated_minutes":12,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-017"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-017: fix: isolate cookie-aware binary HTTP tests (ticket-017)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,38 97,53 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 57m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-017-1024
TICKET ticket-017
HEAD_SHA b2de7a15ff0a632e2d2ebc24eddc1085a8a29735
CORRELATION_ID local-autogrammar-testql-pr-33-ticket-017
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / enforce=PASS","governance / remote lifecycle=PASS","test=PASS"]
INPUT required_checks = ["test"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"autogrammar/testql","pull_request":33,"head_sha":"b2de7a15ff0a632e2d2ebc24eddc1085a8a29735","base_sha":"74f5141237eff330f169d4791a79d38874ff4c73","diff_sha256":"df36ad719abf93b92836f931f1547a86def4792d4c6d54a3d7c2bae647048431"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/TICKETS.md","project/ticket-017/README.md","project/ticket-017/ai-codex.md","project/ticket-017/intent.json","tests/test_api_binary_responses.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"74f5141237eff330f169d4791a79d38874ff4c73","head_sha":"b2de7a15ff0a632e2d2ebc24eddc1085a8a29735","change_digest":"59d62049beda1d8e44dbfc5c3c89f4d50e0792b17ec62b5743073e47f7cb9e5a","score":52,"complexity":"M","estimated_minutes":57,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit e6e8045 into main Oct 1, 2026
3 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/017-binary-http-test-isolation branch October 1, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant